Bump eslint-plugin-n from 18.2.1 to 18.3.0

Bumps [eslint-plugin-n](https://github.com/eslint-community/eslint-plugin-n) from 18.2.1 to 18.3.0.
- [Release notes](https://github.com/eslint-community/eslint-plugin-n/releases)
- [Changelog](https://github.com/eslint-community/eslint-plugin-n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint-community/eslint-plugin-n/compare/v18.2.1...v18.3.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-n
  dependency-version: 18.3.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

README.md

@@ -110,7 +110,6 @@ Every argument is optional.
 | [ignore-pr-updates](#ignore-pr-updates)                             | Override [ignore-updates](#ignore-updates) for PRs only                     |                       |
 | [include-only-assigned](#include-only-assigned)                     | Process only assigned issues                                                | `false`               |
 | [sort-by](#sort-by)                                                 | What to sort issues and PRs by                                              | `created`             |
-| [exempt-issue-types](#exempt-issue-types)                           | Issue types on issues exempted from stale/closed.                           |                       |
 | [only-issue-types](#only-issue-types)                               | Only issues with a matching type are processed as stale/closed.             |                       |
 
 ### List of output options
@@ -568,17 +567,6 @@ Useful to sort the issues and PRs by the specified field. It accepts `created`,
 
 Default value: `created`
 
-#### exempt-issue-types
-
-A comma separated list of issue types that can be assigned to issues to exclude them from being marked as stale
-(e.g: `Bug,Feature`)
-
-If unset (or an empty string), this option will not alter the stale workflow.
-
-If a type is listed in both `exempt-issue-types` and `only-issue-types`, `exempt-issue-types` takes precedence.
-
-Default value: unset
-
 #### only-issue-types
 
 A comma separated list of allowed issue types. Only issues with a matching type will be processed (e.g.: `bug,question`).

__tests__/exempt-issue-types.spec.ts

@@ -1,203 +0,0 @@
-import {Issue} from '../src/classes/issue';
-import {IIssuesProcessorOptions} from '../src/interfaces/issues-processor-options';
-import {IssuesProcessorMock} from './classes/issues-processor-mock';
-import {DefaultProcessorOptions} from './constants/default-processor-options';
-import {generateIssue} from './functions/generate-issue';
-import {alwaysFalseStateMock} from './classes/state-mock';
-
-describe('exempt-issue-types option', () => {
-  test('should skip issues with an exempt type', async () => {
-    const opts: IIssuesProcessorOptions = {
-      ...DefaultProcessorOptions,
-      exemptIssueTypes: 'question,discussion'
-    };
-
-    const TestIssueList: Issue[] = [
-      generateIssue(
-        opts,
-        1,
-        'A bug',
-        '2020-01-01T17:00:00Z',
-        '2020-01-01T17:00:00Z',
-        false,
-        false,
-        [],
-        false,
-        false,
-        undefined,
-        [],
-        'bug'
-      ),
-      generateIssue(
-        opts,
-        2,
-        'A question',
-        '2020-01-01T17:00:00Z',
-        '2020-01-01T17:00:00Z',
-        false,
-        false,
-        [],
-        false,
-        false,
-        undefined,
-        [],
-        'question'
-      ),
-      generateIssue(
-        opts,
-        3,
-        'A discussion',
-        '2020-01-01T17:00:00Z',
-        '2020-01-01T17:00:00Z',
-        false,
-        false,
-        [],
-        false,
-        false,
-        undefined,
-        [],
-        'discussion'
-      )
-    ];
-
-    const processor = new IssuesProcessorMock(
-      opts,
-      alwaysFalseStateMock,
-      async p => (p === 1 ? TestIssueList : []),
-      async () => [],
-      async () => new Date().toDateString()
-    );
-
-    await processor.processIssues(1);
-
-    // The exempt types should not be processed/marked stale
-    expect(processor.staleIssues.map(i => i.title)).toEqual(['A bug']);
-  });
-
-  test('should process all issues if exemptIssueTypes is unset', async () => {
-    const opts: IIssuesProcessorOptions = {
-      ...DefaultProcessorOptions,
-      exemptIssueTypes: ''
-    };
-
-    const TestIssueList: Issue[] = [
-      generateIssue(
-        opts,
-        1,
-        'A bug',
-        '2020-01-01T17:00:00Z',
-        '2020-01-01T17:00:00Z',
-        false,
-        false,
-        [],
-        false,
-        false,
-        undefined,
-        [],
-        'bug'
-      ),
-      generateIssue(
-        opts,
-        2,
-        'A feature',
-        '2020-01-01T17:00:00Z',
-        '2020-01-01T17:00:00Z',
-        false,
-        false,
-        [],
-        false,
-        false,
-        undefined,
-        [],
-        'feature'
-      )
-    ];
-
-    const processor = new IssuesProcessorMock(
-      opts,
-      alwaysFalseStateMock,
-      async p => (p === 1 ? TestIssueList : []),
-      async () => [],
-      async () => new Date().toDateString()
-    );
-
-    await processor.processIssues(1);
-    expect(processor.staleIssues.map(i => i.title)).toEqual([
-      'A bug',
-      'A feature'
-    ]);
-  });
-
-  test('should take precedence over onlyIssueTypes', async () => {
-    const opts: IIssuesProcessorOptions = {
-      ...DefaultProcessorOptions,
-      exemptIssueTypes: 'bug',
-      onlyIssueTypes: 'bug'
-    };
-
-    const TestIssueList: Issue[] = [
-      generateIssue(
-        opts,
-        1,
-        'A bug',
-        '2020-01-01T17:00:00Z',
-        '2020-01-01T17:00:00Z',
-        false,
-        false,
-        [],
-        false,
-        false,
-        undefined,
-        [],
-        'bug'
-      )
-    ];
-
-    const processor = new IssuesProcessorMock(
-      opts,
-      alwaysFalseStateMock,
-      async p => (p === 1 ? TestIssueList : []),
-      async () => [],
-      async () => new Date().toDateString()
-    );
-
-    await processor.processIssues(1);
-    expect(processor.staleIssues).toEqual([]);
-  });
-
-  test('should ignore exemptIssueTypes filter when item is a pull request', async () => {
-    const opts: IIssuesProcessorOptions = {
-      ...DefaultProcessorOptions,
-      exemptIssueTypes: 'bug'
-    };
-
-    const TestIssueList: Issue[] = [
-      generateIssue(
-        opts,
-        1,
-        'A pull request',
-        '2020-01-01T17:00:00Z',
-        '2020-01-01T17:00:00Z',
-        false,
-        true,
-        [],
-        false,
-        false,
-        undefined,
-        [],
-        'bug'
-      )
-    ];
-
-    const processor = new IssuesProcessorMock(
-      opts,
-      alwaysFalseStateMock,
-      async p => (p === 1 ? TestIssueList : []),
-      async () => [],
-      async () => new Date().toDateString()
-    );
-
-    await processor.processIssues(1);
-    expect(processor.staleIssues.map(i => i.title)).toEqual(['A pull request']);
-  });
-});

action.yml

@@ -208,10 +208,6 @@ inputs:
     description: 'Only the issues or the pull requests with an assignee will be marked as stale automatically.'
     default: 'false'
     required: false
-  exempt-issue-types:
-    description: 'Issues with a matching type are exempt from being processed as stale/closed. Defaults to `[]` (disabled) and can be a comma-separated list of issue types.'
-    default: ''
-    required: false
   only-issue-types:
     description: 'Only issues with a matching type are processed as stale/closed. Defaults to `[]` (disabled) and can be a comma-separated list of issue types.'
     default: ''

dist/index.js

@@ -49743,7 +49743,6 @@ var Option;
     Option["IgnorePrUpdates"] = "ignore-pr-updates";
     Option["ExemptDraftPr"] = "exempt-draft-pr";
     Option["CloseIssueReason"] = "close-issue-reason";
-    Option["ExemptIssueTypes"] = "exempt-issue-types";
     Option["OnlyIssueTypes"] = "only-issue-types";
 })(Option || (Option = {}));
 
@@ -51979,19 +51978,6 @@ class IssuesProcessor {
                 return;
             }
         }
-        // exemptIssueTypes wins if both it and onlyIssueTypes are specified
-        if (this.options.exemptIssueTypes && !issue.isPullRequest) {
-            const exemptTypes = this.options.exemptIssueTypes
-                .split(',')
-                .map(t => t.trim().toLowerCase())
-                .filter(Boolean);
-            const issueType = (issue.issue_type || '').toLowerCase();
-            if (exemptTypes.includes(issueType)) {
-                issueLogger.info(`Skipping this $$type because its type ('${issue.issue_type}') is in exemptIssueTypes (${exemptTypes.join(', ')})`);
-                IssuesProcessor._endIssueProcessing(issue);
-                return;
-            }
-        }
         const onlyLabels = wordsToList(this._getOnlyLabels(issue));
         if (onlyLabels.length > 0) {
             issueLogger.info(`The option ${issueLogger.createOptionLink(Option.OnlyLabels)} was specified to only process issues and pull requests with all those labels (${LoggerService.cyan(onlyLabels.length)})`);
@@ -106918,8 +106904,7 @@ function _getAndValidateArgs() {
         exemptDraftPr: getInput('exempt-draft-pr') === 'true',
         closeIssueReason: getInput('close-issue-reason'),
         includeOnlyAssigned: getInput('include-only-assigned') === 'true',
-        onlyIssueTypes: getInput('only-issue-types'),
+        onlyIssueTypes: getInput('only-issue-types')
-        exemptIssueTypes: getInput('exempt-issue-types')
     };
     for (const numberInput of ['days-before-stale']) {
         if (isNaN(parseFloat(getInput(numberInput)))) {

package-lock.json

@@ -28,7 +28,7 @@
         "eslint": "^10.7.0",
         "eslint-config-prettier": "^10.1.8",
         "eslint-plugin-jest": "^29.15.4",
-        "eslint-plugin-n": "^18.2.1",
+        "eslint-plugin-n": "^18.3.0",
         "globals": "^17.7.0",
         "jest": "^30.4.2",
         "jest-silent-reporter": "^0.6.0",
@@ -4748,9 +4748,9 @@
       }
     },
     "node_modules/eslint-plugin-n": {
-      "version": "18.2.1",
+      "version": "18.3.0",
-      "resolved": "https://registry.npmjs.org/eslint-plugin-n/-/eslint-plugin-n-18.2.1.tgz",
+      "resolved": "https://registry.npmjs.org/eslint-plugin-n/-/eslint-plugin-n-18.3.0.tgz",
-      "integrity": "sha512-aO3C9//yq8JIvYOi/T+jPvcZ9hZzpwzbR8esrYpFtgE9vpbyM8kn42AQOtIqYspVmpaSWr8X+nrlQuAJYxXAaw==",
+      "integrity": "sha512-cPVguuDe6DrIPb/qUXHf8P89MaVTUmiYWwpt5gX5AILsvRIiZAxMFXcFR6QHYBksqKJpjfUBlL/RleCJUWcD7w==",
       "dev": true,
       "license": "MIT",
       "dependencies": {

package.json

@@ -57,7 +57,7 @@
     "eslint": "^10.7.0",
     "eslint-config-prettier": "^10.1.8",
     "eslint-plugin-jest": "^29.15.4",
-    "eslint-plugin-n": "^18.2.1",
+    "eslint-plugin-n": "^18.3.0",
     "globals": "^17.7.0",
     "jest": "^30.4.2",
     "jest-silent-reporter": "^0.6.0",

src/classes/issues-processor.ts

@@ -268,24 +268,6 @@ export class IssuesProcessor {
       }
     }
 
-    // exemptIssueTypes wins if both it and onlyIssueTypes are specified
-    if (this.options.exemptIssueTypes && !issue.isPullRequest) {
-      const exemptTypes = this.options.exemptIssueTypes
-        .split(',')
-        .map(t => t.trim().toLowerCase())
-        .filter(Boolean);
-      const issueType = (issue.issue_type || '').toLowerCase();
-      if (exemptTypes.includes(issueType)) {
-        issueLogger.info(
-          `Skipping this $$type because its type ('${
-            issue.issue_type
-          }') is in exemptIssueTypes (${exemptTypes.join(', ')})`
-        );
-        IssuesProcessor._endIssueProcessing(issue);
-        return;
-      }
-    }
-
     const onlyLabels: string[] = wordsToList(this._getOnlyLabels(issue));
 
     if (onlyLabels.length > 0) {

src/enums/option.ts

@@ -50,6 +50,5 @@ export enum Option {
   IgnorePrUpdates = 'ignore-pr-updates',
   ExemptDraftPr = 'exempt-draft-pr',
   CloseIssueReason = 'close-issue-reason',
-  ExemptIssueTypes = 'exempt-issue-types',
   OnlyIssueTypes = 'only-issue-types'
 }

src/interfaces/issues-processor-options.ts

@@ -55,6 +55,5 @@ export interface IIssuesProcessorOptions {
   exemptDraftPr: boolean;
   closeIssueReason: string;
   includeOnlyAssigned: boolean;
-  exemptIssueTypes?: string;
   onlyIssueTypes?: string;
 }

src/main.ts

@@ -125,8 +125,7 @@ function _getAndValidateArgs(): IIssuesProcessorOptions {
     exemptDraftPr: core.getInput('exempt-draft-pr') === 'true',
     closeIssueReason: core.getInput('close-issue-reason'),
     includeOnlyAssigned: core.getInput('include-only-assigned') === 'true',
-    onlyIssueTypes: core.getInput('only-issue-types'),
+    onlyIssueTypes: core.getInput('only-issue-types')
-    exemptIssueTypes: core.getInput('exempt-issue-types')
   };
 
   for (const numberInput of ['days-before-stale']) {