docs: add federation removal investigation tasks

2026-08-30 19:12:21 +03:30
parent 3b61787a62
commit ae90ebed3a
2 changed files with 8 additions and 0 deletions
@@ -398,3 +398,9 @@ Migration order implied by the map: isolate shared infrastructure constructors (
 - `UserInitWallet` now uses named-return transaction finalization: successful execution commits, while any returned error rolls back (including failures after key recovery or trustline submission). Full Wallet tests pass in `4e4f2af`; broader integration coverage remains before W005 completion.
 - Commit-on-success and rollback-on-error behavior is covered by focused application tests in addition to the service wiring. Full Wallet tests pass in `3bc9591`; broader integration coverage remains before W005 completion.
 - Existing-wallet and federation-create wallet paths are covered with repository fakes, alongside transaction finalization tests. Full Wallet tests pass in `15200dc`; broader integration coverage remains before W005 completion.
 ### Federation removal investigation (`A009` / `W013`)
 - Federation is not currently safe to delete outright: wallet persistence links `wallet.federation_id`, transaction records expose nullable `from_federation_id`/`to_federation_id`, generated wallet APIs expose federation messages, and wallet code still has federation lookup/creation paths.
 - Auth has no active federation implementation; its wallet federation client is commented/dead code. Auth’s identity service should remain the owner of identity and national-ID data.
 - The proposed target is reasonable only after consumers are migrated: `user_id → identity_id → wallet_id`, with `wallet_id` still scoped to `asset_id` and Stellar key derivation/custody explicitly preserved. W013 must first identify whether federation addresses or transaction routing are actually supported in production, then remove or retain the model based on evidence and a data/API compatibility plan.
@@ -112,6 +112,7 @@ This is the authoritative execution tracker for the refactor. Work is performed
 | A006 | `DONE` | Extract identity and permission use cases and adapters. | Permission policy/read paths and identity storage, validation, and external verification boundaries are extracted/runtime-wired; full tests and vet pass. |
 | A007 | `DONE` | Replace auth bootstrap with explicit dependency composition. | Auth bootstrap constructs a typed dependency graph for OTP, JWT/session, permission, and identity boundaries; full tests and vet pass. |
 | A008 | `DONE` | Remove superseded auth packages and compatibility shims. | Removed the legacy constructor and all runtime nil/fallback branches superseded by explicit OTP, JWT/session, permission, and identity dependencies; full tests/race/vet pass. |
 | A009 | `TODO` | Audit and remove auth-side federation coupling. | Confirm federation has no live Auth responsibility; remove the commented/dead wallet federation client and document the identity ownership boundary before wallet federation removal. |
 ## Phase 3 — `wallet` architecture
@@ -129,6 +130,7 @@ This is the authoritative execution tracker for the refactor. Work is performed
 | W010 | `TODO` | Separate cron and stream bootstrap from business operations. | Both modes start and stop correctly through explicit dependencies. |
 | W011 | `TODO` | Replace wallet bootstrap with explicit dependency composition. | All five sub-services work independently and together. |
 | W012 | `TODO` | Remove superseded `core/*Imp` packages and shims. | No duplicate business implementations remain. |
 | W013 | `TODO` | Audit and remove redundant wallet federation creation/model. | Trace all federation API, transaction-routing, and persistence consumers; if no supported federation-address use remains, migrate to `user_id → identity_id → wallet_id` (wallets still scoped by asset), remove automatic federation creation, and provide a compatibility/data-migration plan. |
 ## Phase 4 — `api` architecture